Mobile Release v1.109.2 #56782
Merged
Mobile Release v1.109.2 #56782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bring changes from #55134 to the mobile code * Mobile - RichText - Force focus when the block is selected but the textinput is not, for cases when merging blocks. * Update Buttons integration test due to a change in the logic of the app where deleting the only button available does not remove the block * Mobile - Heading block - Adds integration test for merging a Heading block with an empty Paragraph block * Mobile - Paragraph block - Adds integration test to check that backspacing in an empty Paragraph block merges succesfully with the previous block and keeps the focus on the TextInput * Mobile - RichText - Set selection values to be the last character position when merging and adds some comments to explain what is doing * Mobile - Paragraph block test - Use focusTextInput to check the TextInput is in focused instead of checking for the fomatting toolbar button * Rename shouldFocusTextInputAfterUpdate to shouldFocusTextInputAfterMerge * Update CHANGELOG
* Add polyfill for Element.prototype.remove * Enable unit tests of `raw-handling` API filter `ms-list-converter` * Update `react-native-editor` changelog
… format (#56686) * Fix issue related to receiving undefined ref in text color format In rare cases, `TextColorEdit` might receive the `RichText` ref as undefined. This ref is used to get the background color of the text and use it in the toolbar button. * Update `react-native-editor` changelog * Add test to cover undefined `contentRef` case * Correct typo in `changelog`
…available (#56723) * Add native workaround for HTML block in `htmlToBlocks` * Add raw handling tests This file is a clone of the same `blocks-raw-handling.js` file located in `gutenberg/test/integration`. The reason for the separation is that several of the test cases fail in the native version. For now, we are going to skip them, but we'd need to work on them in the future. Once all issues in tests are addressed, we'll remove this file in favor of the original one. * Update blocks raw handling test snapshot with original values * Disable more pasteHandler test cases due to not matching test snapshot * Comment obsolete snapshots of blocks raw handling tests The reason for commenting them instead of removing is that, in the future, we'll restore them once we address the failing test cases.
…#56757) Address rare cases where a null value is passed to a heading block, causing a crash.
fluiddot
added
[Type] Build Tooling
fluiddot
commented
Dec 5, 2023
| if ( currentFormat?.type === FORMAT_TYPE ) { | ||
| const className = currentFormat?.attributes?.class; | ||
| currentFormat.attributes.style = | ||
| currentFormat.attributes.style.replace( / /g, '' ); |
There was a problem hiding this comment.
Removing this line will avoid the crash referenced in wordpress-mobile/gutenberg-mobile#6432.
4 tasks
SiobhyB
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Approved via wordpress-mobile/gutenberg-mobile#6442 (review).
# Conflicts: # package-lock.json # packages/react-native-aztec/package.json # packages/react-native-bridge/package.json # packages/react-native-editor/CHANGELOG.md # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 044ef9e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7104853784
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release 1.109.2 of the react-native-editor and Gutenberg-Mobile.
Here you can see the changes between versions 1.109.1 and 1.109.2.